feat: move to scikit-build-core #126
Merged
+26
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/skbuild
branch
from
92487d9 to
80f4c10
Compare
|
Thank you!! 😃 |
nightlark
reviewed
Mar 22, 2024
|
Do you really want to support manylinux1? It's been abandoned by most projects & is years past EoL. The oldest cmake we still ship is 2010 (and highly recommend 2014). I can require binaries and see what the newest cmake to support manylinux1 was. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
Hopefully I remembered how to do that. :) |
|
FYI, the last cmake we shipped for manylinux1 was 3.22.6. $ PIP_ONLY_BINARY=:all: docker run -e PIP_ONLY_BINARY --rm quay.io/pypa/manylinux1_x86_64 pipx run cmake --version
...
cmake version 3.22.6
... |
|
For supporting manylinux1 it's mostly been if the builds work with minimal hassle, might as well keep building them for users that haven't been able to update their Python/OS yet -- not sure if I'm reading it right, but from https://mayeut.github.io/manylinux-timeline/ it looks like there's maybe 3-5% of users with Python <=3.7 that only support manylinux1. |
henryiii
commented
Mar 22, 2024
nightlark
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #104.
I didn't include these files in the existing wheel:
as the licenses are already in the correct place in the diet-info folder, people don't need the CMakeLists.txt or README.md, and these get installed to the root of the environment! For a virtualenv, that's bad:
And for a global install, that's horrible:
The second commit uses a single macOS universal wheel with ARM and Intel tags also included. I could remove that if you'd prefer multiple smaller wheels. As it is, pip will never download the universal wheel, since it will get the most specific one.